Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform ed25519 usage across SSH docs #1105

Closed
wants to merge 2 commits into from
Closed

Uniform ed25519 usage across SSH docs #1105

wants to merge 2 commits into from

Conversation

jezhou8
Copy link

@jezhou8 jezhou8 commented Nov 5, 2020

Why: I was trying to add a new ssh key and noticed that github now accepts the more secure ed25519 encryption standard! However, in the documentation, some parts of the tutorial still used referenced the old RSA steps. So I wanted to help make the documentation more uniform and use ed25519.

What's being changed:

github change

Check off the following:

@welcome
Copy link

welcome bot commented Nov 5, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@nschonni
Copy link
Contributor

nschonni commented Nov 5, 2020

Seems like there are a few competing PRs for this #1074 and #1063, I guess we'll see which lands first 😄

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 13, 2020
@janiceilene
Copy link
Contributor

I missed this one, sorry about that @jezhou8! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core and removed stale There is no recent activity on this issue or pull request labels Nov 16, 2020
@shati-patel
Copy link
Contributor

Hello @jezhou8! Thank you for proposing a pull request for fixing this problem. We're really grateful for the help we've been receiving from the community 💟

Your fix was totally right, but we had a slightly earlier pull request (#1074) that fixed the same issue, so I'm going to close this pull request ✔️ Thank you again for contributing 😊

This was referenced Jan 17, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 18, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@irinaqwerty852 irinaqwerty852 mentioned this pull request Oct 6, 2022
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Oct 7, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2022
Open
@irinaqwerty852 irinaqwerty852 mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jezhou8 @nschonni @janiceilene @shati-patel